Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0020 Proposal: Use TypeScript in Wallets Admin Client #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OlhaD
Copy link

@OlhaD OlhaD commented Apr 7, 2023

No description provided.

- Good, because we will have same advantages as with option 1
- Good, because it will be much easier for new developers to start with
- Bad, because it will require additional project configuration

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see option 2 as preferable to start with. It will bring us many benefits and not require too much effort to work with it for new people. If it goes well, we can gradually move to option 1 using more and more features if needed.

@OlhaD OlhaD changed the title 0020 proposal use typescript in wallets client 0020 Proposal: Use TypeScript in Wallets Admin Client Apr 7, 2023
@dadiorchen
Copy link
Contributor

I think the principle of using or not using TS is about the complicity of the project, if the project is going to be complicated, TS brings benefits, in my mind of the admin panel case, the logic and hierarchy will be flat and kind of simple. So I tend to suggest javascript is good enough.

@pranavkparti
Copy link

@OlhaD I prefer option 2 as well. @dadiorchen is right that the project isn't that complicated, and we probably do not need typescript for all parts of the code, but having basic type safety for props and incoming data is really useful. Also makes for better documentation.
One correction though, the Wallet API is implemented in JS currently. Whatever we may decide for the front-end, the back-end definitely needs to be in Typescript. We will need @Kpoke 's input as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants